On Tue, Feb 25, 2025 at 10:00:37PM -0500, Rik van Riel wrote: > @@ -1139,6 +1141,10 @@ static void cpu_detect_tlb_amd(struct cpuinfo_x86 *c) > tlb_lli_2m[ENTRIES] = eax & mask; > > tlb_lli_4m[ENTRIES] = tlb_lli_2m[ENTRIES] >> 1; > + > + /* Max number of pages INVLPGB can invalidate in one shot */ > + if (boot_cpu_has(X86_FEATURE_INVLPGB)) ^^^^^^^^^^^^^ I even sent you an *actual* hunk which you could've merged ontop of yours! https://lore.kernel.org/r/20250224120029.GDZ7xfXV3jMjnbdbGl@fat_crate.local What is the best way to convey to you what needs to be done? Next diff ontop: --- diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index 9f48596da4f0..0e2e9af18cef 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c @@ -1143,7 +1143,7 @@ static void cpu_detect_tlb_amd(struct cpuinfo_x86 *c) tlb_lli_4m[ENTRIES] = tlb_lli_2m[ENTRIES] >> 1; /* Max number of pages INVLPGB can invalidate in one shot */ - if (boot_cpu_has(X86_FEATURE_INVLPGB)) + if (cpu_has(c, X86_FEATURE_INVLPGB)) invlpgb_count_max = (cpuid_edx(0x80000008) & 0xffff) + 1; } Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
