On 2/28/25 13:47, Harry Yoo wrote: > On Thu, Feb 27, 2025 at 05:26:26PM +0100, Vlastimil Babka wrote: >> ---8<--- >> From c38dadde6293cacdb91f95afc3615c22dec5830a Mon Sep 17 00:00:00 2001 >> From: Vlastimil Babka <vbabka@xxxxxxx> >> Date: Thu, 27 Feb 2025 16:05:46 +0100 >> Subject: [PATCH] mm, slab: cleanup slab_bug() parameters >> >> slab_err() has variadic printf arguments but instead of passing them to >> slab_bug() it does vsnprintf() to a buffer and passes %s, buf. >> >> To allow passing them directly, turn slab_bug() to __slab_bug() with a >> va_list parameter, and slab_bug() a wrapper with fmt, ... parameters. >> Then slab_err() can call __slab_bug() without the intermediate buffer. >> >> Also constify fmt everywhere, which also simplifies object_err()'s >> call to slab_bug(). >> >> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx> >> --- > > Looks good to me. > > FWIW, > Reviewed-by: Harry Yoo <harry.yoo@xxxxxxxxxx> Thanks, adding to slab/for-next
