Re: [PATCH -v2] mm: frontswap: fix a wrong if condition in frontswap_shrink

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2012-09-28 22:54, Paul Bolle wrote:
On Fri, 2012-09-28 at 11:43 +0800, Zhenzhong Duan wrote:
On 2012-09-27 19:35, Paul Bolle wrote:
I think setting pages_to_unuse to zero here is not needed. It is
initiated to zero in frontswap_shrink() and hasn't been touched since.
See my patch at https://lkml.org/lkml/2012/9/27/250.
Yes, it's unneeded. But I didn't see warning as you said in above link
when run 'make V=1 mm/frontswap.o'.
Not even before applying your patch? Anyhow, after applying your patch
the warnings gone here too.
I tested both cases, no warning, also didn't see -Wmaybe-uninitialized when make.
My env is el5. gcc version 4.1.2 20080704 (Red Hat 4.1.2-52)
Maybe your gcc built in/implicit spec use that option?
thanks
zduan

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]