On Thu, Feb 27, 2025 at 10:38:47AM -0800, Eric Biggers wrote: > On Thu, Feb 27, 2025 at 06:11:04PM +0000, Yosry Ahmed wrote: > > On Thu, Feb 27, 2025 at 06:15:09PM +0800, Herbert Xu wrote: > > > Use the acomp virtual address interface. > > > > > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > > > > I can't speak to the rest of the series, but I like what this patch is > > doing in zswap. Together with the recent zsmalloc changes, we should be > > able to drop the alternative memcpy path completely, without needing to > > use kmap_to_page() or removing the warning the highmem code. > > > > Thanks for doing this! > > Well, unfortunately this patchset still uses sg_init_one() on the virtual > address, so AFAICS it doesn't work with arbitrary virtual addresses. If we cannot pass in highmem addresses then the problem is not solved. Thanks for pointing this out.
