Re: CK1 [07/13] slab: Use common kmalloc_index/kmalloc_size functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 28 Sep 2012, Glauber Costa wrote:

> One nitpick:
>
> >
> > @@ -185,26 +169,19 @@ static __always_inline void *kmalloc_nod
> >  	struct kmem_cache *cachep;
> >
> >  	if (__builtin_constant_p(size)) {
> > -		int i = 0;
> > +		int i;
> >
>
> Although this is technically correct, the former is correct as well, and
> this end up only adding churn to the patch.

What does the "former" refer to?

> Should you decide to remove it, there is another instance of this a bit
> more down.

Remove what?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]