On Wed, Sep 26, 2012 at 06:55:03AM +0530, Raghavendra D Prabhu wrote: > > Hi, > > > * On Sat, Sep 22, 2012 at 08:43:37PM +0800, Fengguang Wu <fengguang.wu@xxxxxxxxx> wrote: > >On Sat, Sep 22, 2012 at 04:03:10PM +0530, raghu.prabhu13@xxxxxxxxx wrote: > >>From: Raghavendra D Prabhu <rprabhu@xxxxxxxxxxx> > >> > >>Return value of a_ops->readpage will be propagated to return value of read_pages > >>and __do_page_cache_readahead. > > > >That does not explain the intention and benefit of this patch.. > > I noticed that force_page_cache_readahead checks return value of > __do_page_cache_readahead but the actual error if any is never > propagated. force_page_cache_readahead()'s return value, in turn, is never used by its callers.. Nor does the other __do_page_cache_readahead() callers care about the error state. So until we find an actual user of the error code, I'd recommend to avoid changing the current code. Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>