On 09/26/2012 11:12 PM, Christoph Lameter wrote: > This patchset cleans up the bootstrap of the allocators > and creates a common function to set up the > kmalloc array. The results are more common > data structures that will simplify further work > on having common functions for all allocators. > The patchset looks good in general, and the few things that need to be fixed that I could spot in this review I've sent already. It seems to touch less bug-prone things than your last round, which is good. Still, given all the small problems we had, I would insist this should get a round of build & boot testing to make sure they don't happen again. Thankfully, we now have Fengguang's marvelous 0-day test system that should be able to find all that. For simplicity, I've uploaded your series to my "slab-common/kmalloc" branch at: git://git.kernel.org/pub/scm/linux/kernel/git/glommer/memcg.git I'll let you know if it spills anything, and you can then fold together with my comments in v2. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>