On Mon, Feb 24, 2025 at 1:02 PM Christoph Hellwig <hch@xxxxxx> wrote: > > On Mon, Feb 24, 2025 at 03:33:29PM +0000, Matthew Wilcox wrote: > > I don't think it needs a comment at all, but the memory allocation > > might be for something other than folios, so your suggested comment > > is misleading. > > Then s/folio/memory/ The context of the comment is error handling. ENOMEM can come from either folio allocation / addition (there's an allocation for xarray node). So is it really wrong to say folios given the context of the comment? It's not supposed to be a generic comment, but rather one that applies to its context. Maybe this change: - * When NOWAIT I/O fails to allocate folios this could + * When NOWAIT I/O fails to allocate memory for folio Or perhaps just what hch suggested.
