On 24.02.25 15:07, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@xxxxxxxx>
Using a variable string as a printf format can be a security issue
that clang warns about when extra warnings are enabled:
mm/cma.c:239:37: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
239 | snprintf(cma->name, CMA_MAX_NAME, name);
| ^~~~
This one does not appear to be a security issue since the string is
not user controlled, but it's better to avoid the warning.
Use "%s" as the format instead and just pass the name as the argument.
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
---
mm/cma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/cma.c b/mm/cma.c
index ef0206c0f16d..09322b8284bd 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -236,7 +236,7 @@ static int __init cma_new_area(const char *name, phys_addr_t size,
cma_area_count++;
if (name)
- snprintf(cma->name, CMA_MAX_NAME, name);
+ snprintf(cma->name, CMA_MAX_NAME, "%s", name);
else
snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count);
Acked-by: David Hildenbrand <david@xxxxxxxxxx>
--
Cheers,
David / dhildenb
