On 2/24/25 17:34, Christophe Leroy wrote: > > > Le 17/02/2025 à 05:22, Anshuman Khandual a écrit : >> GENERIC_PTDUMP gets selected on powerpc explicitly and hence can be dropped >> off from mpc885_ads_defconfig. >> >> Cc: Madhavan Srinivasan <maddy@xxxxxxxxxxxxx> >> Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx> >> Cc: Nicholas Piggin <npiggin@xxxxxxxxx> >> Cc: Christophe Leroy <christophe.leroy@xxxxxxxxxx> >> Cc: linuxppc-dev@xxxxxxxxxxxxxxxx >> Cc: linux-kernel@xxxxxxxxxxxxxxx >> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx> >> --- >> Just wondering - Should CONFIG_PTDUMP_DEBUGFS be added instead ? > > Yes please do that as a fix to commit e084728393a5 ("powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP") Sure, does the following updated commit message look okay ? arch/powerpc: Drop GENERIC_PTDUMP from mpc885_ads_defconfig GENERIC_PTDUMP gets selected on powerpc explicitly and hence can be dropped off from mpc885_ads_defconfig. Just add CONFIG_PTDUMP_DEBUGFS instead. Fixes: e084728393a5 ("powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP") Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx> > >> >> arch/powerpc/configs/mpc885_ads_defconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/powerpc/configs/mpc885_ads_defconfig b/arch/powerpc/configs/mpc885_ads_defconfig >> index 77306be62e9e..ea6f836407d2 100644 >> --- a/arch/powerpc/configs/mpc885_ads_defconfig >> +++ b/arch/powerpc/configs/mpc885_ads_defconfig >> @@ -78,4 +78,3 @@ CONFIG_DEBUG_VM_PGTABLE=y >> CONFIG_DETECT_HUNG_TASK=y >> CONFIG_BDI_SWITCH=y >> CONFIG_PPC_EARLY_DEBUG=y >> -CONFIG_GENERIC_PTDUMP=y >