At 09/28/2012 04:17 AM, KOSAKI Motohiro Wrote: > On Thu, Sep 27, 2012 at 1:45 AM, <wency@xxxxxxxxxxxxxx> wrote: >> From: Wen Congyang <wency@xxxxxxxxxxxxxx> >> >> hwpoisoned may set when we offline a page by the sysfs interface >> /sys/devices/system/memory/soft_offline_page or >> /sys/devices/system/memory/hard_offline_page. If we don't clear >> this flag when onlining pages, this page can't be freed, and will >> not in free list. So we can't offline these pages again. So we >> should clear this flag when onlining pages. > > This seems wrong fix to me. After offline, memory may or may not > change with new one. Thus we can't assume any memory status. Thus, > we should just forget hwpoison status at _offline_ event. > Yes, agree with you. I will update this patch. Thanks for reviewing. Wen Congyang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>