Re: Add Morton,Peter and David for discussion//Re: [PATCH -next] uprobes: fix two zero old_folio bugs in __replace_page()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Tong Tiangen <tongtiangen@xxxxxxxxxx>
Subject: Re: Add Morton,Peter and David for discussion//Re: [PATCH -next] uprobes: fix two zero old_folio bugs in __replace_page()
From: Oleg Nesterov <oleg@xxxxxxxxxx>
Date: Wed, 19 Feb 2025 16:22:38 +0100
Cc: David Hildenbrand <david@xxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Ian Rogers <irogers@xxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, "Liang, Kan" <kan.liang@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-trace-kernel@xxxxxxxxxxxxxxx, linux-perf-users@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, wangkefeng.wang@xxxxxxxxxx, linux-mm <linux-mm@xxxxxxxxx>
In-reply-to: <24a61833-f389-b074-0d9c-d5ad9efc2046@huawei.com>
References: <20250217123826.88503-1-tongtiangen@huawei.com> <c2924e9e-1a42-a4f6-5066-ea2e15477c11@huawei.com> <3b893634-5453-42d0-b8dc-e9d07988e9e9@redhat.com> <24a61833-f389-b074-0d9c-d5ad9efc2046@huawei.com>
User-agent: Mutt/1.5.24 (2015-08-30)

On 02/18, Tong Tiangen wrote:
>
> OK, Before your rewrite last merged, How about i change the solution to
> just reject them immediately after get_user_page_vma_remote()？

I agree, uprobe_write_opcode() should simply fail if is_zero_page(old_page).

Oleg.

Follow-Ups:
- Re: Add Morton,Peter and David for discussion//Re: [PATCH -next] uprobes: fix two zero old_folio bugs in __replace_page()
  - From: David Hildenbrand

References:
- Add Morton,Peter and David for discussion//Re: [PATCH -next] uprobes: fix two zero old_folio bugs in __replace_page()
  - From: Tong Tiangen
- Re: Add Morton,Peter and David for discussion//Re: [PATCH -next] uprobes: fix two zero old_folio bugs in __replace_page()
  - From: David Hildenbrand
- Re: Add Morton,Peter and David for discussion//Re: [PATCH -next] uprobes: fix two zero old_folio bugs in __replace_page()
  - From: Tong Tiangen

Prev by Date: Re: [PATCH 0/2] hung_task: Dump the blocking task stacktrace
Next by Date: Re: [RFC v2 4/9] khugepaged: generalize alloc_charge_folio for mTHP support
Previous by thread: Re: Add Morton,Peter and David for discussion//Re: [PATCH -next] uprobes: fix two zero old_folio bugs in __replace_page()
Next by thread: Re: Add Morton,Peter and David for discussion//Re: [PATCH -next] uprobes: fix two zero old_folio bugs in __replace_page()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]