On Tue, Feb 18, 2025 at 08:02:09PM +0800, Jingbo Xu wrote: > ... otherwise this is a behavior change for the previous callers of > invalidate_complete_folio2(), e.g. the page invalidation routine. Hm. Shouldn't the check be moved to caller of the helper in mm/filemap.c? Otherwise we would drop pages without writing them back. And lose user's data. -- Kiryl Shutsemau / Kirill A. Shutemov