On Mon, Feb 17, 2025 at 02:33:30PM +0800, Shuai Xue wrote:
> changes singce v1:
> - Patch 1: Fix cur_sev and sev type to `int` per Tony
> - Patch 4: Fix return value to 0 for clean pages per Miaohe
> - Patch 5: pick return value comments of memory-failure()
>
> This patch addresses three regressions identified in memory failure
> handling, as discovered using ras-tools[1]:
>
> - `./einj_mem_uc copyin -f`
> - `./einj_mem_uc futex -f`
> - `./einj_mem_uc instr`
This is not how you write a problem statement and explain why your patches
exist.
You need to state:
1. What are you trying to do
2. What is the expected outcome and why
3. What actually happens and why
4. The fix, in your opinion, should be X or Y
Not quote some ras tools commands. Show me that you actually know what you're
doing and explain the problem in human understandable way. And then we can
talk fixes.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
