On 2/3/25 11:41 PM, Asahi Lina wrote: > > > On 2/3/25 7:22 PM, Danilo Krummrich wrote: >> Hi Lina, >> >> On Sun, Feb 02, 2025 at 10:05:42PM +0900, Asahi Lina wrote: >>> This series refactors the existing Page wrapper to support borrowing >>> `struct page` objects without ownership on the Rust side, and converting >>> page references to/from physical memory addresses. >> >> Thanks for picking this up! >> >> As you know, this has been previously worked on by Abdiel. Kindly drop a note >> if you intend to pick up something up next time, such that we don't end up doing >> duplicated work. > > Sorry! I wasn't sure if this was going to end up submitted over the > holidays so I wasn't in a rush, but I ended up switching gears in the > past couple of weeks and I really needed this feature now (for crashdump > support to debug a really annoying firmware crash). > > I actually only just noticed that the previous v2 already had > Owned/Ownable... I only saw the v3 which didn't, so I didn't realize > there was already a version of that approach in the past. > > ~~ Lina Given the discussion in the other subthreads, it looks like this is not the best approach for page table management and using it for crash dumps of arbitrary physical memory pages raises some eyebrows, so I'm going to abandon this series. Abdiel, if the first two patches are helpful to your work, please feel free to incorporate them into a v4. Otherwise, just go ahead with whatever works for you! ~~ Lina
