On Fri, Feb 14, 2025 at 7:00 AM Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> wrote: > > On Fri, Feb 14, 2025 at 06:39:48AM -0800, Jeff Xu wrote: > > mseal_system_mappings() can be placed in mm.h in this patch, as you > > suggested. But in the near future, it will be moved out of mm.h and find > > a right header. The functionality belongs to exe namespace, because of > > the reasons I put in the commit message and discussions. > > With respect Jeff - and I feel that this might simply be a miscommunciation > here - but this doesn't read wonderfully. 'can be placed' 'it will be moved > out', etc. > > Please try to be respectful of experienced maintainers who are taking their > time to review your code, and respond politely and respectfully. I think > what you meant to say is something more like: > > "I'm more than happy to do that, but I feel that it would be more suited in > a separate header, as this strictly belongs to the kernel functionality > surrounding the execution of code. However we can revisit this at a later > time!" > Thanks! I apologize if my expression appears to be rude. Your revision reflects what I'm trying to say, in better english. > My feeling is that this is exactly what you mean, but you are just > essentially abbreviating this. However it reads rather rudely, which I'm > sure you don't intend. > > Ultimately the fact of the matter is that your series will be merged when > it reaches the standards required of you by the relevant maintainers, as is > the case will all code submitted to the kernel when we reach consensus. > > In this series you have addressed a great number of concerns which has > brought the merging of it very much closer, so I hope we can continue in > the same vein and reach this consensus soon. > > Let's try to avoid any miscommunication which might delay us reaching this > aim! > Thanks ! -Jeff > Thanks, Lorenzo > > > > > Thanks > > -Jeff > > > > -Jeff
