On 2/8/25 11:28, Matthew Wilcox wrote: > On Fri, Jan 31, 2025 at 11:12:23AM -0800, Bart Van Assche wrote: >> Commit 30c2de0a267c ("mm/vmstat: fix a W=1 clang compiler warning") >> suppresses some but not all compiler warnings that are reported by clang >> when building mm/ with W=1. Hence revert commit 30c2de0a267c and instead >> make NR_LRU_BASE and NR_ZONE_LRU_BASE integer constants instead of >> enumeration constants. Additionally, convert the item##_NORMAL constants >> from type enum vm_event_item into int before subtracting ZONE_NORMAL. The >> latter constant has type enum zone_type. > > this patch was NAKed last year Looks like not strongly enough :) > https://lore.kernel.org/all/ZnXC5Xa4R0Mp7FCB@xxxxxxxxxxxxxxxxxxxx/ With the warning now in W=2, want to submit the revert of above, Bart?