On Sat, 8 Sep 2012 17:47:54 -0300 Ezequiel Garcia <elezegarcia@xxxxxxxxx> wrote: > Previously the strndup_user allocation was being done through memdup_user, > and the caller was wrongly traced as being strndup_user > (the correct trace must report the caller of strndup_user). > > This is a common problem: in order to get accurate callsite tracing, > a utils function can't allocate through another utils function, > but instead do the allocation himself (or inlined). > > Here we fix this by creating an always inlined dup_user() function to > performed the real allocation and to be used by memdup_user and strndup_user. This patch increases util.o's text size by 238 bytes. A larger kernel with a worsened cache footprint. And we did this to get marginally improved tracing output? This sounds like a bad tradeoff to me. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>