On 2/7/25 5:01 PM, Linus Torvalds wrote:
On Fri, 7 Feb 2025 at 16:49, Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
Could we possibly please still consider taking this in for 6.14? :(
Since the warning comes from vmstat.h pretty much every object file
generates this warning. clang 19 is getting more widely used now,
its making it hard to see new warnings.
So:
- I build the kernel with clang, but I don't have clang-19, so it's
kind of pointless sending patches that DO NOT EVEN EXPLAIN WHAT THE
WARNINGS ARE.
- and even if you explain *WHAT* the warnings are, please also
explain *WHY* they are valid and should be cared about.
Because honestly, W=1 is literally meant for "warnings that aren't
necessarily valid". That's why they aren't on by default.
So no, I'm certainly not applying unexplained random patches that
don't bother to explain the what or the why. Not for 6.14, not ever.
Fix the patch. Explain the problem. And possibly just disable the warning.
Got it.
Since the patch at the start of this e-mail thread is a follow-up for
commit 30c2de0a267c ("mm/vmstat: fix a W=1 clang compiler warning"), do
you perhaps want me to submit a revert for that commit?
Thanks,
Bart.
