On 02/07/25 at 05:36pm, Kairui Song wrote: > On Wed, Feb 5, 2025 at 5:27 PM Baoquan He <bhe@xxxxxxxxxx> wrote: > > > > These are all made during reviewing and learning below patchset from > > Kairui. > > Thanks, I've noticed some obsolete comments and code, currently > refactoring many parts so some of the functions would be just gone > someday. Thanks a lot for reviewing, Kairui. I have a queued patchset to refactor the old hdd/cluster code, it could be made about 2 years ago. Then I heard you and Chris's presentation in LPC in last fall, and your later rework patchset, just began to notice the big change in swap code which is not what I knew. Sorry, didn't know you are still refactoring the code, so will stop touching swap code, look forward to seeing your new refactoring patches. I will keep an eye so that I can follow the step to update my knowledge about swap code. > But this surely cleans things up and is good to have, refactoring will > take much longer time to happen. Thanks again. Please help add me to CC when you post, I am interested in the new change. > > With the V2 update of "mm/swapfile.c: update the code comment above > swap_count_continued()": > > Reviewed-by: Kairui Song <kasong@xxxxxxxxxxx> > > > [PATCH v3 00/13] mm, swap: rework of swap allocator locks > > BTW, I noticed most patches here are patching legacy code, and not > directly related to that series. > Just to clarify, so people won't need to worry about missing "Fixes:" > or things like that :) LOL, right, at least people following the recent change of swap won't misunderstand.