On Mon, Feb 3, 2025 at 7:49 PM Oleg Nesterov <oleg@xxxxxxxxxx> wrote: > > To avoid the confusion, my question and a note are absolutely offtopic. > > On 02/01, Mateusz Guzik wrote: > > > > @@ -1085,6 +1085,7 @@ SYSCALL_DEFINE2(setpgid, pid_t, pid, pid_t, pgid) > > { > > struct task_struct *p; > > struct task_struct *group_leader = current->group_leader; > > + struct pid *pids[PIDTYPE_MAX] = { 0 }; > > Could you remind me why > > struct pid *pids[PIDTYPE_MAX] = {}; > > is not right? I seem to knew it some time before, but can't recall... > as far as I know this is merely a matter of convention, fwiw a naive grep: $ git grep '= { }' | wc -l 1273 $ git grep '= { 0 }' | wc -l 2031 $ git grep '= {}' | wc -l 5626 that said i can change it to whatever you see fit -- Mateusz Guzik <mjguzik gmail.com>