On 2012-09-21 18:41, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 12, 2012 at 11:39:14AM +0900, Minchan Kim wrote: >> Hi all, >> >> I would like to promote zram/zsmalloc from staging tree. >> I already tried it https://lkml.org/lkml/2012/8/8/37 but I didn't get >> any response from you guys. >> >> I think zram/zsmalloc's code qulity is good and they >> are used for many embedded vendors for a long time. >> So it's proper time to promote them. >> >> The zram should put on under driver/block/. I think it's not >> arguable but the issue is which directory we should keep *zsmalloc*. >> >> Now Nitin want to keep it with zram so it would be in driver/blocks/zram/ >> But I don't like it because zsmalloc touches several fields of struct page >> freely(and AFAIRC, Andrew had a same concern with me) so I want to put >> it under mm/. > > I like the idea of keeping it in /lib or /mm. Actually 'lib' sounds more > appropriate since it is dealing with storing a bunch of pages in a nice > layout for great density purposes. >> >> In addtion, now zcache use it, too so it's rather awkward if we put it >> under dirver/blocks/zram/. >> >> So questions. >> >> To Andrew: >> Is it okay to put it under mm/ ? Or /lib? >> >> To Jens: >> Is it okay to put zram under drvier/block/ If you are okay, I will start sending >> patchset after I sort out zsmalloc's location issue. > > I would think it would be OK. We can certainly put it in drivers/block, I have no issue with that. -- Jens Axboe -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>