On Tue, Sep 18, 2012 at 08:57:27PM -0700, Hugh Dickins wrote: > We should not be seeing non-0 unevictable_pgs_mlockfreed any longer. > So remove free_page_mlock() from the page freeing paths: __PG_MLOCKED > is already in PAGE_FLAGS_CHECK_AT_FREE, so free_pages_check() will now > be checking it, reporting "BUG: Bad page state" if it's ever found set. > Comment UNEVICTABLE_MLOCKFREED and unevictable_pgs_mlockfreed always 0. > > Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx> > Cc: Mel Gorman <mel@xxxxxxxxx> > Cc: Rik van Riel <riel@xxxxxxxxxx> > Cc: Johannes Weiner <hannes@xxxxxxxxxxx> > Cc: Michel Lespinasse <walken@xxxxxxxxxx> > Cc: Ying Han <yinghan@xxxxxxxxxx> Like Johannes I think you should just drop the counter. I find it very unlikely that there is a tool that depends on it existing because it's very hard to draw any useful conclusions from its value unlikes like say pgscan* or pgfault. Acked-by: Mel Gorman <mel@xxxxxxxxx> Thanks Hugh. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>