On Thu, 16 Jan 2025 13:23:59 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> --- a/include/trace/events/kmem.h
> +++ b/include/trace/events/kmem.h
> @@ -9,6 +9,8 @@
> #include <linux/tracepoint.h>
> #include <trace/events/mmflags.h>
>
> +TRACE_DEFINE_GFP_FLAGS
I also tested this only with the above define in mmflags.h and just added
it to kmem.h before sending out. It appears there's a bug in the
TRACE_EVENT_ENUM define that doesn't translate the TRACE_SYSTEM properly
and it created the same variable used for both kmem.h and mmflags.h and the
build failed.
So v2 will also include a fix to TRACE_DEFINE_ENUM().
-- Steve
> +
> TRACE_EVENT(kmem_cache_alloc,
>
> TP_PROTO(unsigned long call_site,
> diff --git a/include/trace/events/mmflags.h b/include/trace/events/mmflags.h
> index bb8a59c6caa2..522bbe3a5fe1 100644
> --- a/include/trace/events/mmflags.h
> +++ b/include/trace/events/mmflags.h
> @@ -15,6 +15,8 @@
>
> #define gfpflag_string(flag) {(__force unsigned long)flag, #flag}
>
> +TRACE_DEFINE_GFP_FLAGS
> +
> #define __def_gfpflag_names \
> gfpflag_string(GFP_TRANSHUGE), \
> gfpflag_string(GFP_TRANSHUGE_LIGHT), \
> --
