On Thu, 16 Jan 2025 11:19:20 -0800 Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 16 Jan 2025 at 11:17, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > > > But they are only defines, they are not created until used. Are you worried > > that it will slow down the compile? > > Yes, and the whole "pointless noise" thing. > > I *look* at header files sometimes. I don't want to see pointless > noise that isn't relevant to the context. > > This is not relevant to non-tracing users. Would it at least be OK to add a comment there to update the tracing code if a new GFP flag is added? /* * If a new GFP flag is added, a new TRACE_DEFINE_ENUM needs to be added * in path/to/where/define/is/made.h */ ? -- Steve
