On Wed, 15 Jan 2025 at 10:03, Thorsten Blum <thorsten.blum@xxxxxxxxx> wrote:
>
> Remove hard-coded strings by using the str_write_read() helper function.
>
> Suggested-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> ---
> mm/kfence/kfence_test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Why only change the one in kfence_test.c?
$ grep '"read"' mm/kfence/*
mm/kfence/kfence_test.c: return r->is_write ? "write" : "read";
mm/kfence/report.c: return is_write ? "write" : "read";
> diff --git a/mm/kfence/kfence_test.c b/mm/kfence/kfence_test.c
> index f65fb182466d..00034e37bc9f 100644
> --- a/mm/kfence/kfence_test.c
> +++ b/mm/kfence/kfence_test.c
> @@ -20,6 +20,7 @@
> #include <linux/slab.h>
> #include <linux/spinlock.h>
> #include <linux/string.h>
> +#include <linux/string_choices.h>
> #include <linux/tracepoint.h>
> #include <trace/events/printk.h>
>
> @@ -88,7 +89,7 @@ struct expect_report {
>
> static const char *get_access_type(const struct expect_report *r)
> {
> - return r->is_write ? "write" : "read";
> + return str_write_read(r->is_write);
> }
>
> /* Check observed report matches information in @r. */
> --
> 2.47.1
>
> --
> You received this message because you are subscribed to the Google Groups "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@xxxxxxxxxxxxxxxx.
> To view this discussion visit https://groups.google.com/d/msgid/kasan-dev/20250115090303.918192-2-thorsten.blum%40linux.dev.
