Re: [PATCH 7/8] mm/mglru: Check PG_dropcache instead of PG_reclaim in lru_gen_folio_seq()

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

To: "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>

Subject: Re: [PATCH 7/8] mm/mglru: Check PG_dropcache instead of PG_reclaim in lru_gen_folio_seq()

From: David Hildenbrand <david@xxxxxxxxxx>

Date: Mon, 13 Jan 2025 11:09:48 +0100

Cc: "Jason A. Donenfeld" <Jason@xxxxxxxxx>, Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>, Chengming Zhou <chengming.zhou@xxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Dan Carpenter <dan.carpenter@xxxxxxxxxx>, David Airlie <airlied@xxxxxxxxx>, Hao Ge <gehao@xxxxxxxxxx>, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>, Johannes Weiner <hannes@xxxxxxxxxxx>, Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Masami Hiramatsu <mhiramat@xxxxxxxxxx>, Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>, Miklos Szeredi <miklos@xxxxxxxxxx>, Nhat Pham <nphamcs@xxxxxxxxx>, Oscar Salvador <osalvador@xxxxxxx>, Ran Xiaokai <ran.xiaokai@xxxxxxxxxx>, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>, Simona Vetter <simona@xxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Tvrtko Ursulin <tursulin@xxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Yosry Ahmed <yosryahmed@xxxxxxxxxx>, Yu Zhao <yuzhao@xxxxxxxxxx>, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-trace-kernel@xxxxxxxxxxxxxxx

In-reply-to: <20250113093453.1932083-8-kirill.shutemov@linux.intel.com>

Organization: Red Hat

References: <20250113093453.1932083-1-kirill.shutemov@linux.intel.com> <20250113093453.1932083-8-kirill.shutemov@linux.intel.com>

User-agent: Mozilla Thunderbird

On 13.01.25 10:34, Kirill A. Shutemov wrote:

Kernel sets PG_dropcache instead of PG_reclaim everywhere. Check
PG_dropcache in lru_gen_folio_seq().


Subject and description PG_dropcache->PG_dropbehind

Apart from that LGTM

Acked-by: David Hildenbrand <david@xxxxxxxxxx>


--
Cheers,

David / dhildenb