On 1/11/25 21:24, Randy Dunlap wrote: > Hi, > > On 1/11/25 12:12 PM, Vlastimil Babka wrote: >> On 1/11/25 07:32, Randy Dunlap wrote: >>> Use corrected function parameter names to eliminate kernel-doc >>> warnings: >>> >>> slab.h:142: warning: Function parameter or struct member 's' not described in 'slab_folio' >>> slab.h:142: warning: Excess function parameter 'slab' description in 'slab_folio' >>> slab.h:168: warning: Function parameter or struct member 's' not described in 'slab_page' >>> slab.h:168: warning: Excess function parameter 'slab' description in 'slab_page' >> >> I'm unable to get those warnings with "make htmldocs", what exactly do I >> need to run? >> >>> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >>> Cc: Christoph Lameter <cl@xxxxxxxxx> >>> Cc: Pekka Enberg <penberg@xxxxxxxxxx> >>> Cc: David Rientjes <rientjes@xxxxxxxxxx> >>> Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> >>> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >>> Cc: Vlastimil Babka <vbabka@xxxxxxx> >> >> Anyway the problem and fix seem obvious, so applied. Thanks! > > Oops. I should have said something like with 'make W=1' or if > just running scripts/kernel-doc, use -Wall. Thanks, I forgot it's the normal build "make" and not "make htmldocs" (which I've been attempting with W=1) that will produce the warning. Because slab.h is likely not listed for inclusions into the htmldocs. > Sorry.
