Re: [PATCH v3 13/15] mm/page_alloc: Add __alloc_frozen_pages()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 4 Dec 2024 12:10:12 +0100 Vlastimil Babka <vbabka@xxxxxxx> wrote:

> > @@ -4804,14 +4804,24 @@ struct page *__alloc_pages_noprof(gfp_t gfp, unsigned int order,
> >  		free_frozen_pages(page, order);
> >  		page = NULL;
> >  	}
> > -	if (page)
> > -		set_page_refcounted(page);
> >  
> >  	trace_mm_page_alloc(page, order, alloc_gfp, ac.migratetype);
> >  	kmsan_alloc_page(page, order, alloc_gfp);
> >  
> >  	return page;
> >  }
> > +EXPORT_SYMBOL(__alloc_frozen_pages_noprof);
> 
> Since there's no user, we should't export. If a user appears (I can imagine
> e.g. KVM), it should be EXPORT_SYMBOL_GPL(). As should have been the rest of
> symbols here, but oh well.

I'll move this into mm-stable, but could we please address this at some
point?




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux