On Sun, 12 Jan 2025 10:21:40 -0800 Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> >
> > fbae2d44aa1df7 Petr Mladek 2016-10-11 901
> > fbae2d44aa1df7 Petr Mladek 2016-10-11 902 /**
> > 1bc3c5db9becd0 Randy Dunlap 2025-01-10 903 * kthread_create_worker_on_node - create a kthread worker
> > dbf52682cb0286 Petr Mladek 2016-10-11 904 * @flags: flags modifying the default behavior of the worker
> > fbae2d44aa1df7 Petr Mladek 2016-10-11 905 * @namefmt: printf-style name for the kthread worker (task).
> > fbae2d44aa1df7 Petr Mladek 2016-10-11 906 *
> > fbae2d44aa1df7 Petr Mladek 2016-10-11 907 * Returns a pointer to the allocated worker on success, ERR_PTR(-ENOMEM)
> > fbae2d44aa1df7 Petr Mladek 2016-10-11 908 * when the needed structures could not get allocated, and ERR_PTR(-EINTR)
> > d25c83c6606ffc Petr Mladek 2022-03-15 909 * when the caller was killed by a fatal signal.
> > fbae2d44aa1df7 Petr Mladek 2016-10-11 910 */
> > fbae2d44aa1df7 Petr Mladek 2016-10-11 911 struct kthread_worker *
> > dbf52682cb0286 Petr Mladek 2016-10-11 912 kthread_create_worker(unsigned int flags, const char namefmt[], ...)
> > fbae2d44aa1df7 Petr Mladek 2016-10-11 @913 {
>
> @Andrew: I don't know how to handle this. My patch applies correctly to linux-next
> where this function name has been changed. It looks like 0day is applying it
> to mainline linux + your tree(s?) for testing.
It appears to be a fix against Frederic's b1e125dcbcea ("kthread: Unify
kthread_create_on_cpu() and kthread_create_worker_on_cpu() automatic
format") so it would best be carried in whatever tree holds
b1e125dcbcea.
From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Subject: kthread: modify kernel-doc function name to match code
Date: Fri, 10 Jan 2025 22:30:08 -0800
kthread.c:1073: warning: expecting prototype for kthread_create_worker(). Prototype was for kthread_create_worker_on_node() instead
Link: https://lkml.kernel.org/r/20250111063008.910712-1-rdunlap@xxxxxxxxxxxxx
Fixes: b1e125dcbcea ("kthread: Unify kthread_create_on_cpu() and kthread_create_worker_on_cpu() automatic format")
Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Cc: Frederic Weisbecker <frederic@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/kthread.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/kernel/kthread.c~kthread-modify-kernel-doc-function-name-to-match-code
+++ a/kernel/kthread.c
@@ -900,7 +900,7 @@ fail_task:
}
/**
- * kthread_create_worker - create a kthread worker
+ * kthread_create_worker_on_node - create a kthread worker
* @flags: flags modifying the default behavior of the worker
* @namefmt: printf-style name for the kthread worker (task).
*
_
