On Fri, Jan 10, 2025 at 12:47:42PM +0000, Lorenzo Stoakes wrote: > On Thu, Jan 09, 2025 at 10:59:04AM -0800, Isaac J. Manjarres wrote: > > memfd_create() is a pretty busy function that could be easier to read > > if some of the logic was split out into helper functions. > > > > Therefore, split the flags sanitization, name allocation, and file > > structure allocation into their own helper functions. > > > > No functional change. > > > > Signed-off-by: Isaac J. Manjarres <isaacmanjarres@xxxxxxxxxx> > > Great this looks good now, thanks! > > Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> > > I agree with Alice that the comment re: kfree() is superfluous, not > critical, but if you want to do a v4 feel free to migrate tags to that. > Thanks! Yes, I'll go ahead and do that. --Isaac
