On Thu, Jan 09, 2025 at 03:04:48PM +0800, Zhenhua Huang wrote: > On 2025/1/8 18:11, Anshuman Khandual wrote: > > Just wondering why not start with PUD level itself ? Although SUBSECTION_SHIFT > > might never reach the PUD level but this will help keep the flags calculations > > bit simple and ready for all future changes. > > > > I suppose that it's because these are significantly larger than 2M, whereas > Catalin assumed SUBSECTION_SIZE would not increase? > His comment: > "should cover any changes to SUBSECTION_SHIFT making it *smaller* than 2MB. > " Yeah, I was thinking of having fewer code lines. Otherwise the compiler would likely optimise them anyway to a single assignment. -- Catalin
