On Wed, 12 Sep 2012, Hugh Dickins wrote:
> > @@ -1825,6 +1825,7 @@ static bool khugepaged_prealloc_page(struct page **hpage, bool *wait)
> > return false;
> >
> > *wait = false;
> > + *hpage = NULL;
> > khugepaged_alloc_sleep();
> > } else if (*hpage) {
> > put_page(*hpage);
>
> The unshown line just below this is
>
> *hpage = NULL;
>
> I do wish you would take the "*hpage = NULL;" out of if and else blocks
> and place it once below both.
Hold on, I'm being unreasonable: that's an "else if", and I've no good
reason to request you to set *hpage = NULL when it's already NULL.
It would be okay if you did, but there's no reason for me to prefer it.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>