Re: [PATCH 05/12] x86/mm: add INVLPGB support code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/2/25 04:42, Borislav Petkov wrote:
>> +#define INVLPGB_VA			BIT(0)
>> +#define INVLPGB_PCID			BIT(1)
>> +#define INVLPGB_ASID			BIT(2)
>> +#define INVLPGB_INCLUDE_GLOBAL		BIT(3)
>> +#define INVLPGB_FINAL_ONLY		BIT(4)
>> +#define INVLPGB_INCLUDE_NESTED		BIT(5)
> Please add only the defines which are actually being used. Ditto for the
> functions.

There's some precedent for defining them all up front, like we did for
invpcid_flush_*().

For INVPCID, there are four variants and two of them got used up front.
But I get that it's a balancing act between having untested code that
might bitrot and introducing helpers at a time when someone (Rik) is
very likely to get all the variants coded up correctly.

Rik, how many of these end up being used by the end of the series?




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux