* syzbot <syzbot+882589c97d51a9de68eb@xxxxxxxxxxxxxxxxxxxxxxxxx> [250102 19:47]: > syzbot has bisected this issue to: > > commit 5a781ccbd19e4664babcbe4b4ead7aa2b9283d22 > Author: Vinicius Costa Gomes <vinicius.gomes@xxxxxxxxx> > Date: Sat Sep 29 00:59:43 2018 +0000 > > tc: Add support for configuring the taprio scheduler > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=117df818580000 > start commit: feffde684ac2 Merge tag 'for-6.13-rc1-tag' of git://git.ker.. > git tree: upstream > final oops: https://syzkaller.appspot.com/x/report.txt?x=137df818580000 > console output: https://syzkaller.appspot.com/x/log.txt?x=157df818580000 > kernel config: https://syzkaller.appspot.com/x/.config?x=50c7a61469ce77e7 > dashboard link: https://syzkaller.appspot.com/bug?extid=882589c97d51a9de68eb > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10e8a8df980000 > > Reported-by: syzbot+882589c97d51a9de68eb@xxxxxxxxxxxxxxxxxxxxxxxxx > Fixes: 5a781ccbd19e ("tc: Add support for configuring the taprio scheduler") > > For information about bisection process see: https://goo.gl/tpsmEJ#bisection > This looks wrong, if this is a bug (which looks like it is since it has a syzbot reproducer?), then it's different than the previous two reports and probably not related. Vinicius, Looking at the patch, it seems you missed some users of -1 vs TAPRIO_ALL_GATES_OPEN in taprio_peek(). The comment in taprio_dequeue() is useful - maybe the gate_mask rcu lock/unlock could be a function and have that comment live in a static inline function? Thanks, Liam
