> >diff --git a/drivers/cxl/hmu.h b/drivers/cxl/hmu.h > >new file mode 100644 > >index 000000000000..c4798ed9764b > >--- /dev/null > >+++ b/drivers/cxl/hmu.h > >@@ -0,0 +1,23 @@ > >+/* SPDX-License-Identifier: GPL-2.0-only */ > >+/* > >+ * Copyright(c) 2024 Huawei > >+ * CXL Specification rev 3.2 Setion 8.2.8 (CHMU Register Interface) > >+ */ > >+#ifndef CXL_HMU_H > >+#define CXL_HMU_H > >+#include <linux/device.h> > > No compilation errors even by removing this header. > I think this inclusion is not required. > Also found similar include at drivers/cxl/pmu.h Kernel generally follows include what you use principles to avoid future issues due to reorganization of headers etc. Here struct device definition is needed below so this header should be included. If there are other cases that do not do this, they should be fixed (there are ongoing efforts to clean this up btw by adding the missing includes). > > >+ > >+#define CXL_HMU_REGMAP_SIZE 0xe00 /* Table 8-32 CXL 3.0 specification */ > > Above Macro CXL_HMU_REGMAP_SIZE is not used, So we should remove it. > Its comment is also not appropriate Not sure on the comment being in appropriate but sure this define can go away (and the comment with it). Thanks for taking a look. Jonathan
