On Tue, Sep 11, 2012 at 04:34:55PM -0700, Andrew Morton wrote: > Alas, try_to_compact_pages()'s kerneldoc altogether forgets to describe > this argument. Mel's > mm-compaction-capture-a-suitable-high-order-page-immediately-when-it-is-made-available.patch > adds a `pages' arg and forgets to document that as well. > *slaps* This covers both of them. ---8<--- mm: compaction: Update try_to_compact_pages kernel doc comment Parameters were added without documentation, tut tut. Signed-off-by: Mel Gorman <mgorman@xxxxxxx> --- mm/compaction.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/compaction.c b/mm/compaction.c index 364e12f..614f18b 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -919,6 +919,8 @@ int sysctl_extfrag_threshold = 500; * @gfp_mask: The GFP mask of the current allocation * @nodemask: The allowed nodes to allocate from * @sync: Whether migration is synchronous or not + * @contended: Return value that is true if compaction was aborted due to lock contention + * @page: Optionally capture a free page of the requested order during compaction * * This is the main entry point for direct page compaction. */ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>