On Tue, 2024-12-31 at 17:19 +0100, Borislav Petkov wrote: > On Tue, Dec 31, 2024 at 11:11:51AM -0500, Rik van Riel wrote: > > Will do. Between your feedback, the suggestions > > from Qi and Nadav, and the kernel test robot > > flagging some build issues without CONFIG_CPU_SUP_AMD, > > there's enough to warrant a v4 :) > > Yes, just take your time pls. I need to get through the rest, first, > in the > coming days. > I'm incorporating the feedback I have so far, and will test with those improvements. I'll wait for you to finish making your way through before coming up with a v4 :) I do have a question about the second to last patch "x86/mm: enable AMD translation cache extensions" It looks like with this patch the translation cache extensions get enabled (when I read back the MSR), but the AMD manual suggests I may need to enable EFER.TCE separately on every CPU? -- All Rights Reversed.