Mike Rapoport <rppt@xxxxxxxxxx> wrote on Monday 23 December 2024 at 15:12 > > On Sun, Dec 22, 2024 at 07:15:37PM +0800, Guo Weikang wrote: > > Before SLUB initialization, various subsystems used memblock_alloc to > > allocate memory. In most cases, when memory allocation fails, an immediate > > panic is required. To simplify this behavior and reduce repetitive checks, > > introduce `memblock_alloc_or_panic`. This function ensures that memory > > allocation failures result in a panic automatically, improving code > > readability and consistency across subsystems that require this behavior. > > > > Changelog: > > ---------- > > v1: initial version > > v2: add __memblock_alloc_or_panic support panic output caller > > v3: panic output phys_addr_t use printk's %pap > > v4: make __memblock_alloc_or_panic out-of-line, move to memblock.c > > v6: Fix CI compile error > > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221000.r1NzXJUO-lkp@xxxxxxxxx/ > > v6: Fix CI compile warinigs > > Links to CI: https://lore.kernel.org/oe-kbuild-all/202412221259.JuGNAUCq-lkp@xxxxxxxxx/ > > v7: add chagelog and adjust function declaration alignment format > > ---------- > > > > Signed-off-by: Guo Weikang <guoweikang.kernel@xxxxxxxxx> > > Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > Reviewed-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx> > > Acked-by: Xi Ruoyao <xry111@xxxxxxxxxxx> > > If people commented on your patch it does not mean you should add > Reviewed-by or Acked-by tags for them. Wait for explicit tags from the > reviewers. First of all, thank you for your reminder and patience. In fact, this is the first time I received a patch discussion when submitting a patch. About Reviewed-by or Acked-by tags, I will not add it myself in the future. Regarding this patch, do I need to provide a new patch to update it? Or will you modify it? Looking forward to your reply > > And don't respin that often, "Reviewers are busy people and may not get to > your patch right away" [1]. > OK, I will be more patient and update after confirming that there are no more comments. > [1] https://docs.kernel.org/process/submitting-patches.html > > > -- > Sincerely yours, > Mike. -- Best regards, Guo
