Hi Peter, Qi, On 19/12/2024 18:19, Peter Zijlstra wrote: > On Thu, Dec 19, 2024 at 04:44:16PM +0000, Kevin Brodsky wrote: >> Besides the ptlock management at PTE/PMD level, all the >> pagetable_*_[cd]tor have the same implementation. Introduce common >> helpers for all levels to reduce the duplication. > Uff, I forgot to Cc you on the discussion here, sorry!: > > https://lkml.kernel.org/r/cover.1734526570.git.zhengqi.arch@xxxxxxxxxxxxx > > we now have two series doing more or less overlapping things :/ > > You can in fact trivially merge the all the implementations -- the > apparent non-common bit (ptlock_free) is a no-op for all those other > levels because they'll be having ptdesc->lock == NULL. Ah that is good to know, thanks for letting me know about that and Qi's series! Fortunately there isn't that much overlap between our series - I think we can easily sort this out. Qi, shall we collaborate to make our series complementary? I believe my series covers patch 2 and 4 of your series, but it goes further by covering all levels and all architectures, and patches introducing ctor/dtor are already split as Alexander suggested on your series. So my suggestion would be: * Remove patch 1 in my series - I'd just introduce pagetable_{p4d,pgd}_[cd]tor with the same implementation as pagetable_pud_[cd]tor. * Remove patch 2 and 4 from your series and rebase it on mine. Let me know if that makes sense, if so I'll post a v2. Cheers, - Kevin
