On 12/19/24 08:44, Kevin Brodsky wrote: > +---------------+-------------------------+-----------------------+--------------+------------------------------------+ > | x86 | Y | Y | Y/N | kmem_cache at pgd level if PAE | > +---------------+-------------------------+-----------------------+--------------+------------------------------------+ This is a really rare series that adds functionality _and_ removes code overall. It looks really good to me. The x86 implementation seems to be captured just fine in the generic one: Acked-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> One super tiny nit is that the PAE pgd _can_ be allocated using __get_free_pages(). It was originally there for Xen, but I think it's being used for PTI only at this point and the comments are wrong-ish. I kinda think we should just get rid of the 32-bit kmem_cache entirely.