On 09/10/2012 05:06 PM, Fengguang Wu wrote: > On Mon, Sep 10, 2012 at 04:58:02PM +0400, Glauber Costa wrote: >> On 09/10/2012 04:57 PM, Fengguang Wu wrote: >>> Glauber, >>> >>> The patch entitled >>> >>> sl[au]b: Allocate objects from memcg cache >>> >>> changes >>> >>> include/linux/slub_def.h | 15 ++++++++++----- >>> >>> which triggers this warning: >>> >>> drivers/video/riva/fbdev.c:281:9: sparse: preprocessor token MAX_LEVEL redefined >>> >>> It's the MAX_LEVEL that is defined in include/linux/idr.h. >>> >>> MAX_LEVEL is obviously too generic. Better adding some prefix to it? >>> >> >> I don't see any MAX_LEVEL definition in this patch. You say it is >> defined in include/linux/idr.h, and as the diffstat shows, I am not >> touching this file. > > It's a rather *unexpected* side effect. You changed slub_def.h to > include memcontrol.h/cgroup.h which in turn includes idr.h. > Indeed. >> I think this needs patching independently. > > Yes, sure. And perhaps send it for quick inclusion before your patches? > I agree. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>