On Tue, Dec 17, 2024 at 9:58 PM Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote: > > What I mean is, functions like __free_unref_page() and > free_unref_page_commit() now accept fpi_flags, but any flags other > than FPI_TRYLOCK are essentially ignored, also not very clear. They're not ignored. They are just not useful in this context. The code rules over comment. If you have a concrete suggestion on how to improve the comment please say so.