Re: [PATCH v4 5/5] libfs: Use d_children list to iterate simple_offset directories

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 14, 2024 at 12:13:30PM -0500, Chuck Lever wrote:
> > > +/* Cf. find_next_child() */
> > > +static struct dentry *find_next_sibling_locked(struct dentry *parent,
> > > +                           struct dentry *dentry)
> > 
> > There might be a better name for this function.

There might be better calling conventions for it, TBH.
AFAICS, all callers are directly surrounded by grabbing/releasing
->d_lock on parent.  Why not fold that in, and to hell with any
mentionings of "locked" in the name...




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux