Re: [PATCH] mm: fix outdated incorrect code comments for handle_mm_fault()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Jinliang Zheng <alexjlzheng@xxxxxxxxx> [241212 22:18]:
> Signed-off-by: Jinliang Zheng <alexjlzheng@xxxxxxxxxxx>
> ---
>  mm/memory.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index d9af83dd86bb..d7342a726845 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -6159,7 +6159,8 @@ static vm_fault_t sanitize_fault_flags(struct vm_area_struct *vma,
>  }
>  
>  /*
> - * By the time we get here, we already hold the mm semaphore
> + * By the time we get here, we already hold either the VMA lock or the
> + * mmap_Lock (FAULT_FLAG_VMA_LOCK tells you which).
           ^ lower case here please, otherwise looking for mmap_lock
	   could fail. ie: grep mmap_lock..
>   *
>   * The mmap_lock may have been released depending on flags and our
>   * return value.  See filemap_fault() and __folio_lock_or_retry().
> -- 
> 2.41.1
> 
> 




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux