Re: [PATCH v3 4/4] memory-hotplug: fix pages missed by race rather than failng

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(2012/09/07 9:39), Minchan Kim wrote:
> If race between allocation and isolation in memory-hotplug offline
> happens, some pages could be in MIGRATE_MOVABLE of free_list although
> the pageblock's migratetype of the page is MIGRATE_ISOLATE.
> 
> The race could be detected by get_freepage_migratetype
> in __test_page_isolated_in_pageblock. If it is detected, now EBUSY
> gets bubbled all the way up and the hotplug operations fails.
> 
> But better idea is instead of returning and failing memory-hotremove,
> move the free page to the correct list at the time it is detected.
> It could enhance memory-hotremove operation success ratio although
> the race is really rare.
> 
> Suggested-by: Mel Gorman <mgorman@xxxxxxx>
> Signed-off-by: Minchan Kim <minchan@xxxxxxxxxx>

Sounds reasonable. Thank you very much !

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]