On Fri, Aug 31, 2012 at 1:39 AM, Michel Lespinasse <walken@xxxxxxxxxx> wrote: > On Fri, Aug 31, 2012 at 1:35 AM, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: >> On 31/08/12 11:15, Andrew Morton wrote: >>> On Fri, 31 Aug 2012 01:07:24 -0700 Michel Lespinasse <walken@xxxxxxxxxx> wrote: >>>> I thought Andrew had a patch >>>> rbtree-adjust-root-color-in-rb_insert_color-only-when-necessary-fix-perf-compilation >>>> that fixed this though a Makefile change ? >>> >>> Yup. But it's unclear why we should include the header via the cc >>> command line? >> >> Dunno >> >> AFAICS tools/perf/util/include/linux is for fixing up the >> differences between kernel headers and exported kernel headers. >> Hence my change: >> >> diff --git a/tools/perf/util/include/linux/rbtree.h b/tools/perf/util/include/linux/rbtree.h >> index 7a243a1..2a030c5 100644 >> --- a/tools/perf/util/include/linux/rbtree.h >> +++ b/tools/perf/util/include/linux/rbtree.h >> @@ -1 +1,2 @@ >> +#include <stdbool.h> >> #include "../../../../include/linux/rbtree.h" >> >> Alex? > > Ah, makes sense to me. I wasn't previously aware of the > tools/perf/util/include/linux directory. I think your fix is fine. > (I don't understand how you hit the issue given the previous Makefile > fix, but I think your fix looks nicer) Looks like the Makefile change either never landed, or has since been dropped. Can we please get this one picked up? Without it, perf is unbuildable on linux-next. -Olof -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>