On 12/9/24 10:16, David Hildenbrand wrote: > On 06.12.24 20:16, Lorenzo Stoakes wrote: >> There are a number of means of interacting with VMA operations within mm, >> and we have on occasion not been made aware of impactful changes due to >> these sitting in different files, most recently in [0]. >> >> Correct this by bringing all VMA operations under the same section in >> MAINTAINERS. Additionally take the opportunity to combine MEMORY MAPPING >> with VMA as there needn't be two entries as they amount to the same thing. >> >> [0]:https://lore.kernel.org/linux-mm/CAG48ez0siYGB8GP5+Szgj2ovBZAkL6Zi4n6GUAjzzjFV9LTkRQ@xxxxxxxxxxxxxx/ >> >> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> >> --- >> MAINTAINERS | 19 +++++++------------ >> 1 file changed, 7 insertions(+), 12 deletions(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 1e930c7a58b1..95db20c26f5f 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -15060,18 +15060,6 @@ F: tools/mm/ >> F: tools/testing/selftests/mm/ >> N: include/linux/page[-_]* >> >> -MEMORY MAPPING >> -M: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >> -M: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx> >> -M: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> >> -R: Vlastimil Babka <vbabka@xxxxxxx> >> -R: Jann Horn <jannh@xxxxxxxxxx> >> -L: linux-mm@xxxxxxxxx >> -S: Maintained >> -W: http://www.linux-mm.org >> -T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm >> -F: mm/mmap.c >> - >> MEMORY TECHNOLOGY DEVICES (MTD) >> M: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> >> M: Richard Weinberger <richard@xxxxxx> >> @@ -25028,6 +25016,13 @@ L: linux-mm@xxxxxxxxx >> S: Maintained >> W: https://www.linux-mm.org >> T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm >> +F: mm/madvise.c >> +F: mm/mlock.c >> +F: mm/mmap.c >> +F: mm/mprotect.c >> +F: mm/mremap.c >> +F: mm/mseal.c >> +F: mm/msync.c > > Not sure about mprotect.c, mlock.c and madvise.c, though. I'd claim that > the real "magic" they perform is in page table handling and not > primarily VMA handling (yes, both do VMA changes, but they are the > "easy" part ;) ). I'd think that moving vma files into MEMORY MAPPING (and not the other way) would result in a better overal name, that would be a better fit for the newly added files too? > They have much more in common with memory.c, which I wouldn't want to > see in here either. Hm. >
