Hi Herbert, > -----Original Message----- > From: Sridhar, Kanchana P <kanchana.p.sridhar@xxxxxxxxx> > Sent: Monday, November 25, 2024 12:03 PM > To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx; > hannes@xxxxxxxxxxx; yosryahmed@xxxxxxxxxx; nphamcs@xxxxxxxxx; > chengming.zhou@xxxxxxxxx; usamaarif642@xxxxxxxxx; > ryan.roberts@xxxxxxx; ying.huang@xxxxxxxxx; 21cnbao@xxxxxxxxx; > akpm@xxxxxxxxxxxxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx; > davem@xxxxxxxxxxxxx; clabbe@xxxxxxxxxxxx; ardb@xxxxxxxxxx; > ebiggers@xxxxxxxxxx; surenb@xxxxxxxxxx; Accardi, Kristen C > <kristen.c.accardi@xxxxxxxxx>; Feghali, Wajdi K <wajdi.k.feghali@xxxxxxxxx>; > Gopal, Vinodh <vinodh.gopal@xxxxxxxxx>; Sridhar, Kanchana P > <kanchana.p.sridhar@xxxxxxxxx> > Subject: RE: [PATCH v4 01/10] crypto: acomp - Define two new interfaces for > compress/decompress batching. > > > > -----Original Message----- > > From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > > Sent: Monday, November 25, 2024 1:35 AM > > To: Sridhar, Kanchana P <kanchana.p.sridhar@xxxxxxxxx> > > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx; > > hannes@xxxxxxxxxxx; yosryahmed@xxxxxxxxxx; nphamcs@xxxxxxxxx; > > chengming.zhou@xxxxxxxxx; usamaarif642@xxxxxxxxx; > > ryan.roberts@xxxxxxx; ying.huang@xxxxxxxxx; 21cnbao@xxxxxxxxx; > > akpm@xxxxxxxxxxxxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx; > > davem@xxxxxxxxxxxxx; clabbe@xxxxxxxxxxxx; ardb@xxxxxxxxxx; > > ebiggers@xxxxxxxxxx; surenb@xxxxxxxxxx; Accardi, Kristen C > > <kristen.c.accardi@xxxxxxxxx>; Feghali, Wajdi K > <wajdi.k.feghali@xxxxxxxxx>; > > Gopal, Vinodh <vinodh.gopal@xxxxxxxxx> > > Subject: Re: [PATCH v4 01/10] crypto: acomp - Define two new interfaces > for > > compress/decompress batching. > > > > On Fri, Nov 22, 2024 at 11:01:18PM -0800, Kanchana P Sridhar wrote: > > > This commit adds batch_compress() and batch_decompress() interfaces > to: > > > > > > struct acomp_alg > > > struct crypto_acomp > > > > > > This allows the iaa_crypto Intel IAA driver to register implementations for > > > the batch_compress() and batch_decompress() API, that can subsequently > > be > > > invoked from the kernel zswap/zram swap modules to > > compress/decompress > > > up to CRYPTO_BATCH_SIZE (i.e. 8) pages in parallel in the IAA hardware > > > accelerator to improve swapout/swapin performance. > > > > > > A new helper function acomp_has_async_batching() can be invoked to > > query > > > if a crypto_acomp has registered these batch_compress and > > batch_decompress > > > interfaces. > > > > > > Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@xxxxxxxxx> > > > --- > > > crypto/acompress.c | 2 + > > > include/crypto/acompress.h | 91 > +++++++++++++++++++++++++++++ > > > include/crypto/internal/acompress.h | 16 +++++ > > > 3 files changed, 109 insertions(+) > > > > This should be rebased on top of my request chaining patch: > > > > https://lore.kernel.org/linux- > > > crypto/677614fbdc70b31df2e26483c8d2cd1510c8af91.1730021644.git.herb > > ert@xxxxxxxxxxxxxxxxxxx/ > > > > Request chaining provides a perfect fit for batching. I wanted to make sure I understand your suggestion: Are you suggesting we implement request chaining for "struct acomp_req" similar to how this is being done for "struct ahash_request" in your patch? I guess I was a bit confused by your comment about rebasing, which would imply a direct use of the request chaining API you've provided for "crypto hash". I would appreciate it if you could clarify. Thanks, Kanchana > > Thanks Herbert. I am working on integrating the request chaining with > the iaa_crypto driver, expecting to have this ready for v5. > > Thanks, > Kanchana > > > > > Cheers, > > -- > > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > > Home Page: http://gondor.apana.org.au/~herbert/ > > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
