Re: [PATCH] slab: Fix too strict alignment check in create_cache()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 22/11/24 04:30, Guenter Roeck wrote:
On Thu, Nov 21, 2024 at 09:23:28AM -0800, Christoph Lameter (Ampere) wrote:
On Thu, 21 Nov 2024, Geert Uytterhoeven wrote:

Linux has supported m68k since last century.

Yeah I fondly remember the 80s where 68K systems were always out of reach
for me to have. The dream system that I never could get my hands on. The
creme de la creme du jour. I just had to be content with the 6800 and
6502 processors. Then IBM started the sick road down the 8088, 8086
that led from crap to more crap. Sigh.

Any new such assumptions are fixed quickly (at least in the kernel).
If you need a specific alignment, make sure to use __aligned and/or
appropriate padding in structures.
And yes, the compiler knows, and provides __alignof__.

How do you deal with torn reads/writes in such a scenario? Is this UP
only?

Linux does not support (rate) SMP m68k machines.

Ah. Ok that explains it.

Do we really need to maintain support for a platform that has been
obsolete for decade and does not even support SMP?

Since this keeps coming up, I think there is a much more important
question to ask:

Do we really need to continue supporting nommu machines ? Is anyone
but me even boot testing those ?

Yes. Across many architectures. And yes on every release, and for m68k building
and testing on every rc for nommu at a minimum.

I rarely hit build or testing problems on nonmmu targets. At least every kernel
release I build and test armnommu (including thumb2 on cortex), m68k, RISC-V and
xtensa. They are all easy, qemu targets for them all. Thats just me. So I would
guess there are others building and testing too.

But what has that got to do with this thread, seems somewhat tangential to the
discussions here so far...

Regards
Greg






[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux